Set an output template for media download filename #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philmcmahon
commented
Feb 21, 2025
| @@ -17,7 +17,7 @@ const extractInfoJson = (infoJsonPath: string): MediaMetadata => { | |||
| title: json.title, | |||
| extension: json.ext, | |||
| filename: json.filename, | |||
| mediaPath: `${json.filename}.${json.ext}`, | |||
| mediaPath: `${json.filename}`, | |||
There was a problem hiding this comment.
the .${json.ext} is not longer needed here as 'ext' always gets included in the filename thanks to the output template
zekehuntergreen
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
I found an issue where the filename of the file downloaded by yt-dlp isn't consistent - for videos from some services it included the file extension whereas for others (in this case bluesky) it didn't, which resulted in the upload to s3 step failing as it had the wrong filename. This PR fixes that by explicitly including the file extension in the downloaded filename using an output template.
How to test
Tested on CODE - it works